Skip to content

Conversation

@praveenkumar
Copy link
Member

@praveenkumar praveenkumar commented Nov 12, 2025

Looks like macos-13 is now depricated so replace those with macos-15 and macos-26.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated macOS runner versions in CI/CD workflows to newer versions (macOS-15-intel, macOS-15, and macOS-26), ensuring builds run on current environments.

Looks like macos-13 is now depricated so replace those with macos-15 and
macos-26.
@openshift-ci openshift-ci bot requested review from cfergeau and lstocchi November 12, 2025 06:10
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

GitHub Actions workflow files are updated to use newer macOS runner versions. The macOS-13 and macOS-14 runners are replaced with macOS-15-intel, macOS-15, and macOS-26 in the CI/CD matrix configurations.

Changes

Cohort / File(s) Summary
CI/CD Runner Updates
.github/workflows/macos-installer.yml, .github/workflows/make-check.yml
macOS runner matrix versions updated: macOS-13 and macOS-14 replaced with macOS-15-intel/macOS-15 (macos-installer.yml) and macOS-15/macOS-26 (make-check.yml); ubuntu runners unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify macOS-26 version identifier is intentional and valid
  • Confirm runner version availability in GitHub Actions

Poem

🐰 Hop, hop! The runners all get new boots,
macOS-15's here with fresher roots,
Intel joins the dance, and numbers climb high,
CI/CD pipelines reaching for the sky! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required template sections including type of change, proposed changes checklist, testing details, and contribution checklist. Complete the PR description by adding type of change (mark 'Chore'), detailed proposed changes list, testing approach, and contribution checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating macOS workflow runners to the latest macOS versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 517fa29 and 3391f98.

📒 Files selected for processing (2)
  • .github/workflows/macos-installer.yml (1 hunks)
  • .github/workflows/make-check.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build (macOS-15, 1.24)
  • GitHub Check: build (ubuntu-22.04, 1.24)
  • GitHub Check: build-installer (windows-2022, 1.24)
  • GitHub Check: Konflux kflux-prd-rh02 / crc-binary-on-pull-request
🔇 Additional comments (2)
.github/workflows/make-check.yml (1)

14-15: No issues found. The runner versions are available and the coverage choice is intentional.

Both macOS-15 and macOS-26 are confirmed available GitHub Actions runners as of November 2025. The difference in macOS versions between make-check.yml and macos-installer.yml is intentional and reflects their different purposes:

  • make-check.yml is a general CI check that runs make check across multiple platforms (macOS-15, macOS-26, Ubuntu variants). Using the latest stable and preview macOS versions ensures broad compatibility and forward-compatibility testing.
  • macos-installer.yml is specialized for building a universal macOS installer, which requires architecture-specific testing (macOS-15-intel for Intel + macOS-15 for ARM). The intel-specific variant is not needed in the general check workflow.
.github/workflows/macos-installer.yml (1)

20-21: macOS-15-intel and macOS-15 runners are officially available and stable.

These are valid GitHub Actions runner versions: macos-15-intel for Intel (x86_64) machines and macos-15 for arm64 (Apple Silicon). As official GitHub-hosted runners, they support standard development workflows including Go setup, compilation, and sudo access. No stability or compatibility concerns identified.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 3391f98 link false /test security
ci/prow/e2e-crc 3391f98 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- macOS-13
- macOS-14
- macOS-15-intel
- macOS-15
Copy link
Contributor

@cfergeau cfergeau Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is preexisting, but macos-15 is a more common spelling for runner names

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I suggest is s/macOS/macos

uses: actions/upload-artifact@v5
with:
name: macOS Installer (${{ matrix.os }})
path: "./out/macos-universal/crc-macos-installer.pkg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a universal installer, why do we need to run it both on intel and apple silicon?

Copy link
Member Author

@praveenkumar praveenkumar Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make sure it works on intel and silicon both ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building/uploading the installer on both platforms is not really useful imo, as long as we can build it on apple silicon, we’re good.
But after that there are also a few steps which install the .pkg and run crc setup which I hadn’t noticed.
Imo the installer build and the installer tests on Apple Silicon/Intel should be separate, we build one installer on Apple Silicon, and we test it on the 2 platforms, it’s closer to how we are going to release it.
And I’m not sure running crc setup is great, as it’s going to download the bundle, which can take time.

- macOS-13
- macOS-14
- macOS-15
- macOS-26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as in 3391f98#r2526670082

uses: actions/upload-artifact@v5
with:
name: macOS Installer (${{ matrix.os }})
path: "./out/macos-universal/crc-macos-installer.pkg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building/uploading the installer on both platforms is not really useful imo, as long as we can build it on apple silicon, we’re good.
But after that there are also a few steps which install the .pkg and run crc setup which I hadn’t noticed.
Imo the installer build and the installer tests on Apple Silicon/Intel should be separate, we build one installer on Apple Silicon, and we test it on the 2 platforms, it’s closer to how we are going to release it.
And I’m not sure running crc setup is great, as it’s going to download the bundle, which can take time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants