Remove returns success even if the VM doesn't exist

crc delete won't fail and correctly delete ~/.crc/machines/crc directory now when the VM is absent.
crc-org · Sep 6, 2021 · a4cda99 · a4cda99
1 parent bd18c39
commit a4cda99
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/libvirt/libvirt.go b/pkg/libvirt/libvirt.go
@@ -434,8 +434,9 @@ func (d *Driver) Stop() error {
 
 func (d *Driver) Remove() error {
 	log.Debugf("Removing VM %s", d.MachineName)
-	if err := d.validateVMRef(); err != nil {
-		return err
+	_ = d.validateVMRef()
+	if !d.vmLoaded {
+		return nil
 	}
 	// Note: If we switch to qcow disks instead of raw the user
 	//       could take a snapshot.  If you do, then Undefine