check if conn is nil and return error in function virtiofsSupported
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce66284. we can do a check for if conn is nil in the virtiofsSupported function itself instead of moving it around to pass the unit test
if conn is nil we cannot check if virtiofs is supported so return ErrorNotSupported
|
Is this still needed? |
i'd say nice to have (no release needed just for this) |
cfergeau
reviewed
Sep 28, 2022
| @@ -159,6 +159,10 @@ func domainXML(d *Driver, machineType string) (string, error) { | |||
| } | |||
|
|
|||
| func virtiofsSupported(conn *libvirt.Connect) error { | |||
| if conn == nil { | |||
| return drivers.ErrNotSupported | |||
There was a problem hiding this comment.
return ErrInvalidLibvirtConnection, or ErrInvalidArgs would be more accurate, but I don't think we have such error constants.
cfergeau
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.