Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore rosetta's failure to install #160

Closed
cfergeau opened this issue Jul 2, 2024 · 1 comment · Fixed by #202
Closed

Add option to ignore rosetta's failure to install #160

cfergeau opened this issue Jul 2, 2024 · 1 comment · Fixed by #202
Assignees
@lstocchi

Comments

@cfergeau
Copy link
Collaborator

cfergeau commented Jul 2, 2024

When being prompted for rosetta installation, it's possible for the user to cancel the installation if they don't want rosetta. If the user does this, vfkit will exit with an error as rosetta was requested but it's not available.
podman would like for this behaviour to be optional, see containers/podman#23153
@cfergeau cfergeau mentioned this issue Jul 2, 2024
Open
@cfergeau
Copy link
Collaborator Author

cfergeau commented Oct 2, 2024

It's related to these APIs in the virtualization framework https://developer.apple.com/documentation/virtualization/running_intel_binaries_in_linux_vms_with_rosetta?language=objc
I think they are available in Code-Hex/vz

lstocchi pushed a commit to lstocchi/vfkit that referenced this issue Oct 8, 2024
rosetta: add option to ignore rosetta failure when installation cance…
97bd448 
…lled

    this adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation do not succeed for some reason (e.g. user cancelled installation).
    So far, if the rosetta installation was cancelled or failed vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set or it is false.
    This will be used by podman bc there could be a fallback and rosetta could also be not mandatory containers/podman#23153
it fixes crc-org#160
@lstocchi lstocchi mentioned this issue Oct 8, 2024
Merged
lstocchi pushed a commit to lstocchi/vfkit that referenced this issue Oct 8, 2024
rosetta: add option to ignore rosetta failure when installation cance…
86e7fa9 
…lled

    this adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation do not succeed for some reason (e.g. user cancelled installation).
    So far, if the rosetta installation was cancelled or failed vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set or it is false.
    This will be used by podman bc there could be a fallback and rosetta could also be not mandatory containers/podman#23153
it fixes crc-org#160
@lstocchi lstocchi moved this to Ready for review in Project planning: crc Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Project planning: crc Oct 17, 2024
lstocchi pushed a commit to lstocchi/vfkit that referenced this issue Oct 30, 2024
rosetta: add option to ignore rosetta failure when installation cance…
efd6527 
…lled

    this adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation do not succeed for some reason (e.g. user cancelled installation).
    So far, if the rosetta installation was cancelled or failed vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set or it is false.
    This will be used by podman bc there could be a fallback and rosetta could also be not mandatory containers/podman#23153
it fixes crc-org#160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstocchi lstocchi

Labels
None yet
Projects
Project planning: crc
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rosetta: add option to ignore rosetta failure when installation cancelled lstocchi/vfkit
2 participants
@cfergeau @lstocchi