Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc improvements. #141

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

williamtheaker
Copy link
Contributor

This is a pretty minor change is mostly just capitalizing words like Linux.

The only change I think pointing out is in doc/usage.md where the truncate command is changed to use a flag that works on both the GNU implementation and the FreeBSD version shipped with macOS.

@openshift-ci openshift-ci bot requested review from cfergeau and praveenkumar May 9, 2024 18:51
Copy link

openshift-ci bot commented May 9, 2024

Hi @williamtheaker. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough cleanups! Minor wording question, apart from this this looks good to me!

doc/missing-vz-api.md Outdated Show resolved Hide resolved
Co-authored-by: William Theaker <williamtheaker@users.noreply.github.com>
@cfergeau
Copy link
Collaborator

/lgtm
/approve

Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e643dc0 into crc-org:main May 16, 2024
5 checks passed
@williamtheaker williamtheaker deleted the wt.docs branch October 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants