contrib: update start-crc-bundle to use UEFI boot #201
Conversation
There was a problem hiding this comment.
Not sure about the use of chore in the short log, doesn't this word have a negative connotation? https://www.merriam-webster.com/dictionary/chore I think of 3. when I see it, even if I guess it's meant as 2.?
In my prev projects we used conventional commits and |
lstocchi
changed the title
|
@cfergeau I updated the label to the commit to |
| --kernel "${BUNDLE_PATH}/${KERNEL}" \ | ||
| --initrd "${BUNDLE_PATH}/${INITRD}" \ | ||
| --kernel-cmdline "${CMDLINE}" \ | ||
| --bootloader efi,variable-store=efistore.nvram,create \ |
There was a problem hiding this comment.
create will ensure that efistore.nvram is created, we don't need to reuse "$HOME/.crc/machines/crc/efistore.nvram" which may not exist
Using a new efi variable store will ensure we are as close as possible to a 'blank state' for our VM.
There was a problem hiding this comment.
ah, i misunderstood your prev comment. Updated
lstocchi
force-pushed
the
i198
branch
2 times, most recently
from
497978d to
1e629bc
Compare
it removes all the legacy kernel related options (kernel, initrd, kernel-cmdline) and replace them with the --bootloader efi.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it removes all the legacy kernel related options (kernel, initrd, kernel-cmdline) and replace them with the --bootloader efi.
I found out that there is an efistore.nvram file inside the
.crc/machine.crcpath. It looks logical to use it but I'm not sure if the path can be different based on the bundle_path or anything else.