Add Restful service #29
Conversation
yeah vfkit version is good to have (possibly with git hash if that's easy to get). |
|
should be updated now |
baude
force-pushed
the
rest
branch
3 times, most recently
from
8a21b0f to
bdbc7d3
Compare
| cmd.Flags().StringArrayVarP(&opts.Devices, "device", "d", []string{}, "devices") | ||
|
|
||
| cmd.Flags().StringVar(&opts.LogLevel, "log-level", "", "set log level") | ||
| cmd.Flags().StringVar(&opts.RestfulURI, "restful-uri", DefaultRestfulURI, "URI address for RestFul services") |
There was a problem hiding this comment.
Any reason for using none:// instead of "" as the default?
There was a problem hiding this comment.
i prefer this approach because the default IS none and this saves us a conditional check later ...
|
/lgtm |
add restful service to VFKit which defaults to `tcp://localhost:8081`. The URL can be changed using the newly introduced --restful-uri option. The schemes may be `tcp` or `unix` (unix domain socket). The service for the unix domain implementation is incomplete and should be considered a TODO still. users can also opt out of the service with a `--restful-uri none`. the restful service now replies to three endpoints: /vm/state GET which returns the state of the vm /vm/state POST which allows for a state change /vm/inspect GET which returns basic information about the virtual machine error handling for the endpoints needs to be completed still. these endpoints should return http response codes (like 200) based on the error handling. this can be completed in a subsequent PR. /version GET should also probably be added. I was unsure if we should return the version of vfkit (my first inclination) or some sort of API version. maybe we should return both? added tests for new content where applicable Signed-off-by: Brent Baude <bbaude@redhat.com>
|
I have updated the PR per your wishes |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: baude, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add restful service to VFKit which defaults to
tcp://localhost:8081. The URL can be changed using the newly introduced --restful-uri option. The schemes may betcporunix(unix domain socket). The service for the unix domain implementation is incomplete and should be considered a TODO still. users can also opt out of the service with a--restful-uri none.the restful service now replies to three endpoints:
/vm/state GET which returns the state of the vm
/vm/state POST which allows for a state change
/vm/inspect GET which returns basic information about the virtual machine
error handling for the endpoints needs to be completed still. these endpoints should return http response codes (like 200) based on the error handling. this can be completed in a subsequent PR.
/version GET should also probably be added. I was unsure if we should return the version of vfkit (my first inclination) or some sort of API version. maybe we should return both?
added tests for new content where applicable