Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtiofs: Allow to add multiple virtio-fs devices #42

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

cfergeau
Copy link
Collaborator

@cfergeau cfergeau commented Jun 2, 2023

This does the same refactoring as for VirtioBlk in commit 36574dd
and 0a83544

This does not try to detect duplicate mount tags, or to allow to use
multiple directories with the same virtio-fs device.

This partially fixes #41

This does the same refactoring as for VirtioBlk in commit 36574dd
and 0a83544

This does not try to detect duplicate mount tags, or to allow to use
multiple directories with the same virtio-fs device.

This partially fixes crc-org#41
@openshift-ci openshift-ci bot requested review from baude and praveenkumar June 2, 2023 09:17
@baude
Copy link
Collaborator

baude commented Jun 2, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2023
@baude
Copy link
Collaborator

baude commented Jun 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2023
@cfergeau cfergeau merged commit 3d57f09 into crc-org:main Jun 2, 2023
@cfergeau cfergeau deleted the virtiofs branch July 26, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

VirtIoFs devices can have []sharedDirs
2 participants