Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set vfkitVersion to 0.5.0 #65

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Set vfkitVersion to 0.5.0 #65

merged 1 commit into from
Oct 30, 2023

Conversation

cfergeau
Copy link
Collaborator

No description provided.

@openshift-ci openshift-ci bot requested review from anjannath and baude October 27, 2023 11:37
anjannath
anjannath reviewed Oct 30, 2023
View reviewed changes
cmd/vfkit/root.go
@@ -9,7 +9,7 @@ import (
"github.com/spf13/cobra"
)

const vfkitVersion = "0.1.1"
const vfkitVersion = "0.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we skipped some numbers in between, is 0.5.0 used to mean a development release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explanation to the commit log, but when I made the 0.1.1 release, there were some comments that 0.1.1 feels like a very early version, kind of 'alpha' software.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aim is to have 1.0 sooner rather than later :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, i thought maybe you used odd/even versioning :)

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anjannath
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2023
@cfergeau
Set vfkitVersion to 0.5.0
77bb1a0 
This jumps from 0.1.1 to 0.5.0 to better reflect vfkit's maturity.
@openshift-ci openshift-ci bot removed the lgtm label Oct 30, 2023
@anjannath
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2023
@cfergeau cfergeau merged commit f3c783d into crc-org:main Oct 30, 2023
3 checks passed
@cfergeau cfergeau deleted the newver branch October 30, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjannath anjannath anjannath approved these changes

@baude baude Awaiting requested review from baude

Assignees

@anjannath anjannath

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfergeau @anjannath