Add support for nvme devices #78
Conversation
|
Hi @cgwalters. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This depends on crc-org/vfkit#78 and is an alternative to crc-org/vfkit#76 that I like better for fixing containers#21160 It looks like at least UTM switched to NVMe for Linux guests by default for example. [NO NEW TESTS NEEDED] Signed-off-by: Colin Walters <walters@verbum.org>
|
Tested this e2e in concert with containers/podman#21208 and I am also not seeing any corruption. |
|
/ok-to-test |
|
the NVME device is only supported on macOS 14, so this would error on 13. |
pkg/config/virtio.go
Outdated
|
|
||
| func (dev *NVMExpressController) ToCmdLine() ([]string, error) { | ||
| return dev.StorageConfig.ToCmdLine() | ||
| } |
There was a problem hiding this comment.
ToCmdLine and FromOptions are not needed as go will reuse the ones from StorageConfig if they are not implemented.
|
Your fixup LGTM |
This also seems to avoid the disk corruption that we see with virtio-blk; it reportedly has a small performance hit for raw speed, but I think avoiding the double caching (guest and host) is much better from a performance perspective. Signed-off-by: Colin Walters <walters@verbum.org>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
Interestingly, Apple recommends using virtio-blk https://developer.apple.com/videos/play/wwdc2023/10007/?time=630 |
This also seems to avoid the disk corruption that we see with virtio-blk; it reportedly has a small performance hit for raw speed, but I think avoiding the double caching (guest and host) is much better from a performance perspective.