Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Handle context termination for pending callbacks. #55

Merged
merged 2 commits into from
Sep 23, 2021
Merged

server: Handle context termination for pending callbacks. #55

merged 2 commits into from
Sep 23, 2021

Commits on Sep 23, 2021

  1. server: Handle context termination for pending callbacks. 

    Prior to this change, calls pushed from the server to the client would ignore
the context passed to the Callback method. This meant that if the client did
not reply (for example, the client has no support for push calls), the callback
would block forever.

This change makes pending callbacks on the server respect the context that was
passed to the Callback method: When it ends, if the call has not yet received a
response, it is delivered an error from the context and resolved.

Update the documentation on Callback to recommend setting a timeout or deadline
on the context, in cases where the client might not reply.
    @creachadair
    creachadair committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    e80944e View commit details
    Browse the repository at this point in the history

  2. Fix a comment typo.

    @creachadair
    creachadair committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    9dd136f View commit details
    Browse the repository at this point in the history