Revert the interface changes to jhttp.Bridge from #52. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mostly reverts the changes to
jhttp.Bridgefrom #52, but respecting some of the other changes in the package since that was merged. This fixes the problems with ID collisions, by restoring the virtualization.The resulting interface is different from both the original interface (where the bridge accepted a client) and the "simplified" interface (where the bridge accepts a server). Now the bridge behaves more like the local server from the
serverpackage, except that it retains awareness of the HTTP infrastructure.Fixes #57.