-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go version 1.18.2 to fix multiple CVEs #154
Conversation
Sorry for the delay, looking at this now. Cloning your branch results in the cross compile test to fail because of some breaking changes in the toolchain. I'll investigate see what we can do. Note that we plan a v2 soon with windows support which require breaking changes, on that branch, I'll bump the go version to the latest. |
@@ -49,12 +49,12 @@ echo2 "Build for linux." | |||
echo2 " - linux/riscv" | |||
docker build -t creack-pty-test -f Dockerfile.riscv . | |||
|
|||
# Golang dropped support for darwin 32bits since go1.15. Make sure the lib still compile with go1.14 on those archs. | |||
# Golang dropped support for darwin 32bits since go1.15. Make sure the lib still compile with go1.18.2 on those archs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I reverted the changes to that file. This point is to make sure it compiles with go < 1.15 as 1.15 dropped support for darwin/32bits.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/creack/pty](https://togithub.com/creack/pty) | `v1.1.21` -> `v1.1.23` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcreack%2fpty/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcreack%2fpty/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcreack%2fpty/v1.1.21/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcreack%2fpty/v1.1.21/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>creack/pty (github.com/creack/pty)</summary> ### [`v1.1.23`](https://togithub.com/creack/pty/releases/tag/v1.1.23) [Compare Source](https://togithub.com/creack/pty/compare/v1.1.21...v1.1.23) #### What's Changed - Upgrade to go version 1.18.2 to fix multiple CVEs by [@​pinaki124](https://togithub.com/pinaki124) in [https://github.com/creack/pty/pull/154](https://togithub.com/creack/pty/pull/154) - Tests cleanup by [@​creack](https://togithub.com/creack) in [https://github.com/creack/pty/pull/173](https://togithub.com/creack/pty/pull/173) - Revert [#​167](https://togithub.com/creack/pty/issues/167) to avoid race on Linux. by [@​creack](https://togithub.com/creack) in [https://github.com/creack/pty/pull/177](https://togithub.com/creack/pty/pull/177) - Add non-blocking notes by [@​WeidiDeng](https://togithub.com/WeidiDeng) in [https://github.com/creack/pty/pull/180](https://togithub.com/creack/pty/pull/180) - ztypes_openbsd\_32bit_int.go: remove arch list by [@​n2vi](https://togithub.com/n2vi) in [https://github.com/creack/pty/pull/189](https://togithub.com/creack/pty/pull/189) #### New Contributors - [@​pinaki124](https://togithub.com/pinaki124) made their first contribution in [https://github.com/creack/pty/pull/154](https://togithub.com/creack/pty/pull/154) - [@​WeidiDeng](https://togithub.com/WeidiDeng) made their first contribution in [https://github.com/creack/pty/pull/180](https://togithub.com/creack/pty/pull/180) - [@​n2vi](https://togithub.com/n2vi) made their first contribution in [https://github.com/creack/pty/pull/189](https://togithub.com/creack/pty/pull/189) **Full Changelog**: creack/pty@v1.1.20...v1.1.23 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.