Allow defaults library to use UnmarshalText() and UnmarshalJSON() #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface to initialize values
|
Any comment on this PR? I think the build checks fail because of an outdated docker container. |
|
Same demand. #41 |
|
(I'm sorry for not getting back to you sooner. Had a lot on my plate last week...) Great idea! Much obliged!
Fixed on my end. |
|
Released v1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing go types cannot easily be extended by a SetDefaults() function, but they often have an implementation of encoding.TextUnmarshaler and/or json.Unmarshaler interface.
Check for implementation of these two interfaces and try to set a default directly to allow initialization of additional types with this API, e.g. types of the net and netip package.