Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo and a spacing issue in CC BY-NC-ND 4.0 text #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lhmouse
Copy link

@lhmouse lhmouse commented Jun 25, 2024

Fixes

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@lhmouse lhmouse requested review from a team as code owners June 25, 2024 02:21
@lhmouse lhmouse requested review from annatuma and possumbilities and removed request for a team June 25, 2024 02:21
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for cc-legal-tools ready!

Name Link
🔨 Latest commit 86e65d8
🔍 Latest deploy log https://app.netlify.com/sites/cc-legal-tools/deploys/667ad07166e6ab0008aca7fe
😎 Deploy Preview https://deploy-preview-212--cc-legal-tools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TimidRobot TimidRobot self-assigned this Jun 25, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes result in the following title HTML (no change from previous):

<h2 id="legal-code-title">
署名—非商业性使用—禁止演绎 4.0 协议国际版
</h2>

If the spacing around 4.0 shouldn't be there, then additional changes are required.

legacy/legalcode/by-nc-nd_4.0_zh-Hans.html Outdated Show resolved Hide resolved
legalcode/zh_Hans/LC_MESSAGES/by-nc-nd_40.po Outdated Show resolved Hide resolved
@lhmouse
Copy link
Author

lhmouse commented Jun 25, 2024

I will leave something here for reference:

Source specification

(Simplified Chinese) https://hbba.sacinfo.org.cn/attachment/onlineRead/e3ef82e93dd272792f5aacb0f582e62f
20240625215033

OCR'd text

8 空格的规则
8.1中文文本中夹用英文词句时,应根据所选用的中英文字体、字符间距以及排版的视觉效果决定英文词句与中文文字之间是否留有空格间距。如留空格,应保证体例的统一。
示例1:用yes或no回答的问句,可以称为yes-no疑问句。
示例2:在此句中,the little girl in white是名词短语。
8.2 中文文本中夹用英文词句时,如英文部分之前或之后有中文标点符号,则英文部分与中文标点之间不设空格。
示例:介词at常与表示较小地点的名词连用,如:at the bus stop、at the rail way station。
8.3 中文文本中夹用英文句子或段落时,英文句子或段落内部应按英文排版规则留空。
示例:在例句“It is always the best to be on the safe side.”中,it是形式主语。

DeepL translation

8 Rules for Spaces
8.1 When English words and phrases are interspersed in Chinese text, the spacing between English words and phrases and Chinese text should be determined according to the chosen Chinese and English fonts, the spacing between characters and the visual effect of typesetting. If you leave a space, you should ensure the unity of style.
Example 1: A question answered with yes or no is called a yes-no question.
Example 2: In this sentence, the little girl in white is a noun phrase.
8.2 When English words and phrases are interspersed in Chinese text, if the English part is preceded or followed by Chinese punctuation, there is no space between the English part and the Chinese punctuation.
Example: The preposition at is often used in conjunction with a noun indicating a smaller place, such as: at the bus stop, at the rail way station.
8.3 When an English sentence or paragraph is inserted into a Chinese text, the English sentence or paragraph should be left blank according to the English typesetting rules.
Example: In the sentence "It is always the best to be on the safe side.", it is the formal subject.

Explaination

Spacing between western and Chinese text shall be consistent. As seen in the screen shot above, there are some render applications which automatically insert 1/4 spaces or thin spaces if explicit space characters are left out.

lhmouse added 2 commits June 25, 2024 22:03
This matches page titles, as well as the translation for Traditional Chinese.
@lhmouse
Copy link
Author

lhmouse commented Jun 25, 2024

@TimidRobot Force-pushed more fixes about spacing.

The current use of spacing around 4.0 is inconsistent in many files in translation for Simplified Chinese. I have included a commit to fix them all, so they are consistent with translation for Traditional Chinese, where explicit spaces are always inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Translation of CC BY-NC-ND 4.0 for Simplified Chinese contains a typo
2 participants