Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and e2e tests for the HelpSection component #116

Closed
akmadian opened this issue Mar 5, 2020 · 11 comments · Fixed by #144
Closed

Add unit and e2e tests for the HelpSection component #116

akmadian opened this issue Mar 5, 2020 · 11 comments · Fixed by #144
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@akmadian
Copy link
Member

akmadian commented Mar 5, 2020

Unit and e2e tests need to be written for the HelpSection component. Unit tests are done with Jest, and e2e tests are done with nightwatch.

Please remember to test the following things:

  • That individual parts of the component are present when appropriate. (unit and e2e)
  • That any computed props and methods work properly, if there are any. (unit)
  • Any common interactions between the user and component, if there are any. (e2e)
  • Any other functionality that is unique to the component being tested!

Additional Context

@akmadian akmadian added help wanted Open to participation from the community good first issue New-contributor friendly test-coverage labels Mar 5, 2020
@akmadian akmadian mentioned this issue Mar 5, 2020
14 tasks
@kushaggarwal
Copy link

Hello @akmadian I would like to go for this but I am not fully aware as how to proceed so can you please give me a few pointers for same
Thank you

@akmadian
Copy link
Member Author

akmadian commented Mar 5, 2020

Hey @kushaggarwal, I would recommend doing some research on what unit and e2e (end to end) testing is, and how it works. Once you're familiar with the concept of testing and tests, your task is to think of some tests (I've included a general list of things to look at when coming up with tests in the main issue body), and write the code for the tests you've come up with (Vue's guide on unit testing, and the documentation for Jest and Nightwatch will be helpful with this).

I would also recommend looking through the tests directory of this repo to familiarize yourself with how the code is organized.

I could help find some resources about testing for you, but I highly recommend that you try to figure it out on your own first. In the meantime, I'll assign this issue to you. If you've got any questions, please feel free to ask!

@kushaggarwal
Copy link

Okay @akmadian thank you very much for your help will start working towards the same

@hemanth-hk
Copy link
Contributor

@kushaggarwal I found an error in the HelpSection.vue component

HelpSection

Please ask your mentor to include this in your PR or please inform me so that I'll make an issue

@akmadian
Copy link
Member Author

akmadian commented Mar 8, 2020

@hemanth-hk This will be fixed in #129

@hemanth-hk
Copy link
Contributor

Any help @kushaggarwal?

@akmadian
Copy link
Member Author

@hemanth-hk I don't see any progress on @kushaggarwal's fork, so I'm gonna open this up to other contributors, if you'd like to work on this, you can go ahead since it's now free!

@kushaggarwal
Copy link

Hello @akmadian apologies for this delay
Actually I was caught up with my university exams hence wasn't able to attend to this issue

@kushaggarwal
Copy link

@hemanth-hk please continue for the same
Thank you

@akmadian
Copy link
Member Author

No worries @kushaggarwal, I'm also very busy with exams right now :)

@hemanth-hk
Copy link
Contributor

I submitted a PR for this issue, before submitting I saw @kushaggarwal's fork and it didn't had any progress.
I'm sorry if @kushaggarwal was working on this.

@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed test-coverage labels Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants