-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit and e2e tests for HelpSection.vue component #144
Conversation
I was able to mock the $ga of Vue analytics but the method using it, was not returning anything, so I had to return something, hence I returned the return of the $ga.event function Please review and check if I have left any cases like last time |
@hemanth-hk We don't need to mock ga as there's no way I know of to verify that the event was received by ga without writing a bunch more code. Please remove all ga stuff and I'll have another look :) |
When I removed the ga stuff the test coverage was not 100% |
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
It's ok for coverage not to be 100% in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @hemanth-hk !
I removed GA mocking, and will merge this PR.
@obulat I would have removed them if you have just left a comment but please make sure you also remove the return statement form the Helpsection.vue component which I added to check it |
Sorry about that, @hemanth-hk . I wanted to add some changes to quickly clean up errors in the repo to make it easier for other contributors to work on it, that is why I added some more changes here. Unfortunately, I didn't notice the return statement. Could you please create a PR removing it? |
I added them in #154, That would be fine right? |
Sure, you acted before I could reply. Thank you again, the repo is linted and test run well now! |
Fixes #116
Description
I have added the unit and e2e tests for the HelpSection.vue component. And tested it locally
Checklist
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin