Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LocaleChooser responsive #170

Merged
merged 1 commit into from
May 25, 2020
Merged

Make LocaleChooser responsive #170

merged 1 commit into from
May 25, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 24, 2020

Positioning of LocaleChooser is updated with css grid properties. This PR updates styling of the App and LocaleChooser components to be mobile-first.

Fixes

Fixes #164 by @JackieBinya

Description

Update to the LocaleChooser and App styles: makes them mobile-first, and fixes the issue of not showing locale chooser on screens smaller than 1024px.

Screenshots

localhost_8080_ (1)
localhost_8080_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Positioning of LocaleChooser is updated with css grid properties. This PR updates styling of the App and LocaleChooser components to be mobile-first.
@obulat obulat requested review from a team and brenoferreira and removed request for a team May 24, 2020 20:35
@obulat obulat mentioned this pull request May 24, 2020
7 tasks
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is ready, and it looks good to me :) Approved!

@akmadian
Copy link
Member

@obulat Since I'm not sure if this is ready to be merged, I'll leave it to you to push the button :)

@obulat obulat merged commit d6d1519 into master May 25, 2020
@obulat obulat deleted the locale-chooser branch May 25, 2020 08:13
@obulat
Copy link
Contributor Author

obulat commented May 25, 2020

Thank you, Ari! It is ready and I'm merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix position of select language block on screens/devices less than 1024px width.
2 participants