Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "property" instead of "rel" where appropriate; fixes #188 #191

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

fkohrt
Copy link
Contributor

@fkohrt fkohrt commented Oct 19, 2020

Fixes

Fixes #188 by @fkohrt

Description

Replaces all occurrences of the rel attribute with property where appropriate; i.e. where the inner content of the element is targeted (and not the href or src as implied by rel).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@fkohrt fkohrt requested a review from a team as a code owner October 19, 2020 20:18
@fkohrt fkohrt requested review from obulat and removed request for a team October 19, 2020 20:18
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, it is really helpful!

@obulat
Copy link
Contributor

obulat commented Oct 22, 2020

Hey @fkohrt , thanks for your contribution! We were impressed by the quality of your work and your attention to detail, and would like to recognize that. As such, we have assigned you to this PR, and applied the “Great Contribution” label.

If you are unaware, we use these labels in the evaluation of CC Community Teams applications. If you are unfamiliar with CC Community Teams, you can read about it on CC’s Open Source website here. Thanks again, and we hope to see more from you in the future!

@obulat obulat merged commit 2bd105f into creativecommons:master Oct 22, 2020
@fkohrt
Copy link
Contributor Author

fkohrt commented Oct 22, 2020

Oh, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of the rel attribute
2 participants