-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #34 - Unit and e2e tests for CopyButton component #46
Merged
akmadian
merged 11 commits into
creativecommons:master
from
priscilauchoa:copybutton-tests
Oct 7, 2019
Merged
Issue #34 - Unit and e2e tests for CopyButton component #46
akmadian
merged 11 commits into
creativecommons:master
from
priscilauchoa:copybutton-tests
Oct 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilauchoa
changed the title
WIP: Issue #34 - Unit and e2e tests for CopyButton component
Issue #34 - Unit and e2e tests for CopyButton component
Oct 6, 2019
akmadian
previously requested changes
Oct 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of last minute things, then we can merge!
- Please move your e2e test file to
./test/e2e/specs/components/
- Please add the developer certificate of origin in the pull request template to the end of your pull request body just like in the PR template.
Merging! Thanks, Priscila! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #34
Description
Test suite for CopyButton.vue component (./src/components/CopyButton.vue) using Jest to Unit Test and Nightwatch to e2e. The function of this button is to copy the content of a specific element.
Other information
It was necessary to mock an environment to
clipboard.js
library on unit tests, because some inner functions fromclipboard.js
required some api methods fromwindow
anddocument
browser objects, unavailable on Jest.Checklist
Developer Certificate of Origin Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.