-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "alt" attributes to generated HTML icon img elements #507
Add "alt" attributes to generated HTML icon img elements #507
Conversation
✅ Deploy Preview for creativecommons-chooser ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Not sure how the code below is used and if it also needs the same change? Adding the chooser/src/components/LicenseIcons.vue Lines 3 to 9 in 5fdc53f
|
@dijitali are you still hoping to wrap this? |
To improve accessibility
8e3ce37
to
e8d2cf2
Compare
@possumbilities - should be all set now - have removed the prettier autoformatting changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved the conflicts for you. Please see the requested change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work! thank you!
Fixes
Description
Adds a null
alt
element toimg
elements in generated HTML in order to improve accessibility.Tests
See reproduction steps in #505
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin