Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SelectedLicenseCode; review strings #83

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 26, 2020

Description

License Code generation was refactored. Icons for richtext are loaded from local assets folder through LicenseIcons.vue component now, therefore preventing extra downloading and flickering of icons when Attribution Details are changed. Icon links for HTML are created separately. All license code generation is done within the SelectedLicenseCode component.
Extracted strings and string labels were also reviewed.

Other information

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Olga Bulat <obulat@gmail.com>
License Icons in rich text are again generated from local svg files to minimize loading data and flickering of the icons. Links for html icons are different in order to ensure that the links are permanent.
License code generation is done inside the SelectedLicenseCode component.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from akmadian January 26, 2020 20:57
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm approving, but please address my comment about the alt text before merging.

</span>
</li>
</transition-group>
</ul>
<div class="freeworks-status__div">
<a href="https://creativecommons.org/freeworks">
<img v-if="this.freeWorkStatus" src="../assets/license-icons/fc_approved_small.png" alt="" />
<img v-else src="../assets/license-icons/fc_dubious.png" />
<img v-else src="../assets/license-icons/fc_dubious.png" alt=""/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well actually add the alt text

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat merged commit 5899a5b into master Jan 27, 2020
@obulat obulat deleted the license-code-refactor branch January 27, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants