Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Logic to check for optional excerpt #845

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Queen-codes
Copy link

@Queen-codes Queen-codes commented Nov 6, 2024

Fixes

Description

This PR modifies the logic that truncates the first 100 characters of the blog post to serve as the excerpt which checks to see if the author provided an excerpt that can be used. If an excerpt is provided, it is used, if not, it falls to the default behaviour.

Technical details

I modified the logic in posts.html, added the excerpt field to the contents.lr file of the write a blog page, and added an excerpt field to the blog-post.ini file to ensure the excerpt field was read correctly.

Tests

To test that the logic worked, I added a dummy blog post to the entries folder and an excerpt field in the contents.lr file.

Screenshots

The added dummy post for testing
Screenshot 2024-11-06 at 10 14 57

The preview it provided
Screenshot 2024-11-06 at 10 15 02

Write a blog post page to show excerpt field in the format provided
Screenshot 2024-11-06 at 10 56 11

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners November 6, 2024 09:33
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and dhruvkb and removed request for a team November 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add Optional Excerpt Field to Blog Post Format
1 participant