Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync upstream Vocabulary markup, correct syntax errors across contexts #76

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

possumbilities
Copy link
Contributor

@possumbilities possumbilities commented Dec 6, 2024

Description

implements upstream Vocabulary changes from:

Technical details

Note: there will be render errors in other areas (see the top menu for example), as this is an ongoing sync across multiple PRs. The Tests below are specifically for the attribution "captions" and their associated renderings.

Tests

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for creativecommons-prototype ready!

Name Link
🔨 Latest commit 3fc4a7c
🔍 Latest deploy log https://app.netlify.com/sites/creativecommons-prototype/deploys/67530f04429b8b000827a86f
😎 Deploy Preview https://deploy-preview-76--creativecommons-prototype.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities changed the title add missing closing div to default-page context correct syntax errors across contexts Dec 6, 2024
@possumbilities possumbilities changed the title correct syntax errors across contexts sync upstream Vocabulary markup, correct syntax errors across contexts Dec 6, 2024
@possumbilities possumbilities self-assigned this Dec 6, 2024
@possumbilities possumbilities marked this pull request as ready for review December 6, 2024 15:03
@possumbilities possumbilities requested review from a team as code owners December 6, 2024 15:03
@possumbilities possumbilities requested review from JackieBinya and nimishbongale and removed request for a team December 6, 2024 15:03
@possumbilities possumbilities merged commit 785853a into main Dec 6, 2024
4 checks passed
@possumbilities possumbilities deleted the syntax-errors branch December 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants