Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] story vs authored-post vs raw article component labelling and structural mismatches #20

Closed
1 task done
possumbilities opened this issue Jun 6, 2024 · 0 comments · Fixed by #50
Closed
1 task done
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@possumbilities
Copy link
Contributor

possumbilities commented Jun 6, 2024

Description

In a plurality the nature of "stories" or "authored-posts" is non consistent, appearing in various areas in various ways that are not well structured or defined. For example the use of a div vs section vs article.

body.home-index > main > article.authored-posts
body.blog-index > main > article.authored-posts, directly after the main > header
body.blog-index > main > article.authored-posts, directly after the first main > article.authored-posts
body.archive-page > main > div.authored-posts, directly after the main > aside
body.person-page > main > section.authored-posts, directly after the main > header
body.blog-post > main > article.related-posts > article.authored-posts, as the last child of body > main/span>

Expectation

The singular is often referred to as story, but the plural is authored-post this needs resolution. It should be either authored-post and authored-posts OR story and stories OR both handled as differing components (thought that is less likely and less ideal based on current usecases)

In a singular sense they are targeted and marked up as .story, and a classless article element. This needs to be corrected with the appropriately chosen class where possible.

In the plural the parenting wrapper should be using consistently the same element, OR have documented rules for why a change is needed in certain contexts.

Resolution

  • I would be interested in resolving this bug.
@possumbilities possumbilities added 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jun 6, 2024
@possumbilities possumbilities self-assigned this Jun 6, 2024
@possumbilities possumbilities removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
None yet
1 participant