-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify layout handling, create better defaults, improve cascade and naming specificity, add test cases for layout changes/dev #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shafiya-Heena
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this based on the best of my knowledge. Thank you!
7 tasks
7 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of the changes required a cascade of changes in order to fully implement, in addition to the need to create new test cases, hence the size of it. I also inadvertently fixed things as a side effect with other necessary changes.
vocabulary.css
line count was2837
, now2057
|27.5% line count reduction
:before
pseudo element breaks bounds of site and stretches horizontally infinitely, on larger viewports #14story
vsauthored-post
vsraw article
component labelling and structural mismatches #20 (this has been collapsed into the singular/plural component ofpost
andposts
, so that it could provide shared rulesets and better defaults)archive-page
blog-post
default-page
person-page
program-index
program-page
search-index
sidebar
arrangements #25 (does not provide any new contexts with its use, but new layout approach now allows for contexts to be built that can have left or right sidebars.)tests
directory to the specimens for scaffolded test case use in developmentgrid
layout test case (with associatedgrid-test.css
file for explicit layout marker definitions)sidebar
grid-sidebar
layout test case (with associatedgrid-test.css
file for explicit layout marker definitions)sidebar
presentkitchensink
layout test caseh1
is now uniformly centered on all layouts to move the layout to a center bounded baseline rhythm as the default. This improves flow, creates less layout shift, less abrupt title placement changes, and allows negative space to be balanced, rather than overtly heavy on one side in several places. We can still do non-centered alignment (such as theperson-page
header area), when it has adequate balance and flow.header
&footer
footer
license svg graphics paths corrected across all specimensfooter
vocabulary.js
path corrected across all specimensfooter
andheader
have improved specificity placement withinvocabulary.css
sidebar area
now has an explicit class ofsidebar
for better css targetting.post/s
posts
component now nests thepost
components within aul
for better semantics, where appropriate.post
component (plural and singular) has been updated to reflect semantics, structure, and naming.posts
variant of.related
is now better implemented.posts
variant of.featured
is now better implemented, replacing the former use-case of.highlight
blog-index
featured
class is now properly applied to only the "featured posts" area.post
headings are now allh3
more button
changed nested placement to be more semantic, moved fromfooter
into lastposts
component listing as last child.blog-post
, bottomposts
now uses the pseudo-semanticrelated
class, for "related posts" delineation.default-page
context is now classless which is more appropriate since its supposed to represent the "default" applied styled when no body class context is utilized.search-index
post/posts
semantics improved, layout adjustedteam-index
added and styledclosing
asideperson-page
semantics improved, layout adjustedTechnical details
Core work affects not only the
vocabulary.css
file, but also the semantic html within these contexts:archive-page
blog-post
blog-index
default-page
person-page
program-index
program-page
search-index
team-index
Tests
page-level contexts
archive-page
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/archive-page.htmlblog-index
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/blog-index.htmlblog-post
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/blog-post.htmldefault-page
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/default-page.htmlperson-page
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/person-page.htmlprogram-index
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/program-index.htmlprogram-page
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/program-page.htmlsearch-index
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/search-index.htmlteam-index
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/contexts/team-index.htmlscaffold test-case specimens
grid
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/tests/grid.htmlgrid-sidebar
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/tests/grid-sidebar.htmlkitchensink
: https://deploy-preview-50--vocabulary-docs.netlify.app/specimen/tests/kitchensink.htmldocumentation
post
: https://deploy-preview-50--vocabulary-docs.netlify.app/#post-singular-blockposts
: https://deploy-preview-50--vocabulary-docs.netlify.app/#posts-plural-blockChecklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin