Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify layout handling, create better defaults, improve cascade and naming specificity, add test cases for layout changes/dev #50

Merged
merged 62 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
9056e7c
prepare file for new testing code
possumbilities Jul 24, 2024
05ad339
setup baseline grid testing specimen
possumbilities Jul 24, 2024
7e5703b
add kitchensink test with all possible variant components within comp…
possumbilities Jul 24, 2024
af8900d
include testing and refactor css
possumbilities Jul 24, 2024
1bc38b2
add main defaults with expected baseline elements
possumbilities Jul 24, 2024
cf4417e
add posts component baselines
possumbilities Jul 24, 2024
8edb55b
add initial contexts rulesets
possumbilities Jul 24, 2024
08f2788
add attention box at body-level context
possumbilities Jul 24, 2024
0065626
reorder sections for better specificity
possumbilities Jul 24, 2024
e8d1305
remove testing colors
possumbilities Jul 24, 2024
8677c46
perform mild comment cleanup
possumbilities Jul 24, 2024
3fcd5ad
add sidebar class to proper aside for better ruleset targetting
possumbilities Jul 24, 2024
c7f9e46
bind posts and post to proper naming scopes as components on archive-…
possumbilities Jul 24, 2024
9f46f8d
add better descriptive text to grid test page;
possumbilities Jul 24, 2024
b48b4ac
fix pluralize typo
possumbilities Jul 24, 2024
0c0112f
add stylings for nav within sidebar aside
possumbilities Jul 25, 2024
5aaf28f
provide grid tests with and without sidebar
possumbilities Jul 25, 2024
eef4015
add filter nav styling defaults
possumbilities Jul 25, 2024
d60e000
generalize archive-page sample title
possumbilities Jul 25, 2024
c7b9f09
correct post categories selector
possumbilities Jul 25, 2024
4bac19d
rename stories to posts, story to post
possumbilities Jul 25, 2024
39d7587
add proper title to featured post area
possumbilities Jul 25, 2024
70cf05c
add highlight pseudo-semantic class to correct usecase
possumbilities Jul 25, 2024
c396408
adjust more link, footer, attribution-list
possumbilities Jul 25, 2024
f23dfac
change nested placement of more button to correct semantics
possumbilities Jul 25, 2024
77b3be9
add empty footer element to kitchensink for better testing
possumbilities Jul 25, 2024
a816cc5
set baseline alignment on posts to center, then modify sub-elements w…
possumbilities Jul 25, 2024
f5d6292
revise structure of post/posts to nest within ul
possumbilities Jul 25, 2024
889aa61
adjust sizing for typography, correct semantic structure of blog-inde…
possumbilities Jul 25, 2024
f6d9c28
correct typographic rhythm for blog-index without affecting other hea…
possumbilities Jul 25, 2024
80e34d6
change naming for featured posts variant
possumbilities Jul 25, 2024
9f34f3d
improve semantics and styling on search-index
possumbilities Jul 25, 2024
2ef33b6
correct specificity of header padding on search-index
possumbilities Jul 25, 2024
eb4ec55
add styling for type display on post component when present
possumbilities Jul 25, 2024
3d5329d
add contextual styling for attention box in sidebar
possumbilities Aug 7, 2024
11cb953
correct spacing in main header region
possumbilities Aug 7, 2024
234c523
correct naming, semantics, structure of related posts
possumbilities Aug 7, 2024
6c615f7
correct heading flexibility
possumbilities Aug 7, 2024
be5dbc9
correct spacing
possumbilities Aug 7, 2024
7616716
narrow specificity of spacing correction
possumbilities Aug 7, 2024
0ebf790
add layout specifics for header area of person-page context
possumbilities Aug 7, 2024
9cdf930
set default page to have no contextual class
possumbilities Aug 7, 2024
c83685e
add styling for header/footer with apppriate grid settings and specif…
possumbilities Aug 7, 2024
55f93a5
correct path to footer license svg icons
possumbilities Aug 7, 2024
3e7b989
add expand state css ruleset
possumbilities Aug 7, 2024
cc591f3
correct semantics of post/posts
possumbilities Aug 8, 2024
bc7820e
add better case examples for post/posts
possumbilities Aug 8, 2024
ed0e59b
correct responsiveness, fix padding on blog-index
possumbilities Aug 8, 2024
cd3502f
finish baseline responsive contexts
possumbilities Aug 8, 2024
72479e8
adjust sizing/spacing/rhythm blog-index
possumbilities Aug 9, 2024
5be9de1
correct link underline placement
possumbilities Aug 9, 2024
c9db40b
correct display order of thumbnail blog-index
possumbilities Aug 9, 2024
de67327
correct top section spacing, blog-idnex
possumbilities Aug 9, 2024
0fc1438
correct responsive padding team-index
possumbilities Aug 9, 2024
1c15213
add closing section to team-index
possumbilities Aug 9, 2024
49b3529
updaet docs for post/posts
possumbilities Aug 9, 2024
1983ce2
refine documentation for post/posts
possumbilities Aug 9, 2024
d6e904f
lowercase h1 to improve readability
possumbilities Aug 9, 2024
5fb05b5
adjust baseline styles for post only
possumbilities Aug 9, 2024
e60aa4b
add in baseline styling for program-index, program-page contexts
possumbilities Aug 9, 2024
a9eac50
migrate refactor into vocabulary.css
possumbilities Aug 9, 2024
a71857c
change import naming to vocabulary proper
possumbilities Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -523,18 +523,21 @@ <h3><a href="#">Name Here</a></h3>
</code>
</pre>

<h3 id="story-snippet-singular-block">Story Snippet - Singular - Block</h3><a class="permalink" href="#story-snippet-singular-block">permalink</a>
<h3 id="post-singular-block">Post - Singular - Block</h3><a class="permalink" href="#post-singular-block">permalink</a>

<p><span class="distinct">Post</span> components nested within a <span class="distinct">Posts</span> component can be direct children or nested within an html list element (<span class="distinct">ol/ul</span>)</p>

<h4>Expected Contexts</h3>
<ul>
<li><span class="distinct">article.authored-posts article.story</span> </li>

<li><span class="distinct">main > article.post</span> </li>
<li><span class="distinct">main > article.posts > article.post</span> </li>
<li><span class="distinct">article.posts ul > li > article.post</span> </li>
</ul>

<pre>
<code class="lang-html">

<article class="story">
<article class="post">
<header>
<h2><a href="#">Title Here</a></h2>

Expand All @@ -555,23 +558,24 @@ <h2><a href="#">Title Here</a></h2>



<h3 id="stories-snippets-plural-block">Stories Snippets - Plural - Block</h3><a class="permalink" href="#stories-snippets-plural-block">permalink</a>
<h3 id="posts-plural-block">Posts - Plural - Block</h3><a class="permalink" href="#posts-plural-block">permalink</a>

<p><span class="distinct">Posts</span> components support a pseudo-semantic variant class of <span class="distinct">featured</span> or <span class="distinct">related</span>. This helps further describe what they are more specifically, but allows a semantic-ish target for their change in behavior or provided sub-elements. </p>
<h4>Expected Contexts</h3>
<ul>
<li><span class="distinct">body.home-index > main > article.authored-posts</span></li>
<li><span class="distinct">body.blog-index > main > article.authored-posts</span>, directly after the <span class="distinct">main > header</span> </li>
<li><span class="distinct">body.blog-index > main > article.authored-posts</span>, directly after the first <span class="distinct">main > article.authored-posts</span> </li>
<li><span class="distinct">body.archive-page > main > div.authored-posts</span>, directly after the <span class="distinct">main > aside</span> </li>
<li><span class="distinct">body.person-page > main > section.authored-posts</span>, directly after the <span class="distinct">main > header</span> </li>
<li><span class="distinct">body.blog-post > main > article.related-posts > article.authored-posts</span>, as the last child of <span class="distinct">body > main/span> </li>
<li><span class="distinct">main > article.posts</span>, directly after the <span class="distinct">main > header</span> </li>
<li><span class="distinct">body.blog-index > main > article.posts.featured</span>, directly after the <span class="distinct">main > header</span> </li>
<li><span class="distinct">body.blog-index > main > article.posts</span>, directly after the <span class="distinct">main > article.posts.featured</span> </li>
<li><span class="distinct">body.archive-page > main > article.posts</span>, directly after the <span class="distinct">main > aside</span> </li>
<li><span class="distinct">body.person-page > main > article.posts</span>, directly after the <span class="distinct">main > header</span> </li>
<li><span class="distinct">body.blog-post > main > article.posts.related</span>, as the last child of <span class="distinct">body > main</span> </li>

</ul>

<pre>
<code class="lang-html">

<article class="authored-posts">
<article class="posts">

<h2>Title Here</h2>

Expand Down Expand Up @@ -709,7 +713,7 @@ <h3 id="sidebar-region">Sidebar - Region</h3><a class="permalink" href="#sidebar

<h4>Expected Contexts</h3>
<ul>
<li><span class="distinct">body.default-page > aside</span>; optionally after <span class="distinct">main > header</span></li>
<li><span class="distinct">body > aside</span>; optionally after <span class="distinct">main > header</span></li>
<li><span class="distinct">body.archive-page > aside</span>, after <span class="distinct">main > header</span></li>


Expand Down Expand Up @@ -939,7 +943,7 @@ <h3 id="page-header-region">Page Header - Region</h3><a class="permalink" href="

<h4>Expected Contexts</h3>
<ul>
<li><span class="distinct">body.default-page > main > header</span></li>
<li><span class="distinct">body > main > header</span></li>
<li><span class="distinct">body.archive-page > main > header</span></li>
<li><span class="distinct">body.blog-index > main > header</span></li>
<li><span class="distinct">body.blog-post > main > header</span></li>
Expand Down
26 changes: 13 additions & 13 deletions specimen/contexts/archive-page.html
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ <h2>Our Work Relies On You!</h2>
</ol>
</nav> -->

<h1>Blog Archives</h1>
<h1>Archives</h1>

<!-- <span class="byline">by <a href="#">Brigitte Vezina</a>, <a href="#">Ony Anukem</a></span> -->

Expand All @@ -113,7 +113,7 @@ <h1>Blog Archives</h1>

</header>

<aside>
<aside class="sidebar">

<nav class="filter-menu">
<h2>Categories</h2>
Expand Down Expand Up @@ -143,9 +143,9 @@ <h2>Write a post!</h2>
</aside>


<div class="content authored-posts">
<article class="posts">

<article>
<article class="post">
<header>
<h2><a href="#">Open Access in Practice: A Conversation with President Larry Kramer of The Hewlett Foundation</a></h2>
<span class="byline">by <a href="#">Amanda Conway</a>, <a href="#">Ólafur Jónsson</a></span>
Expand All @@ -164,7 +164,7 @@ <h2><a href="#">Open Access in Practice: A Conversation with President Larry Kra
</ul> -->
</article>

<article>
<article class="post">
<header>
<h2><a href="#">Open Access in Practice: A Conversation with President Larry Kramer of The Hewlett Foundation</a></h2>

Expand All @@ -180,7 +180,7 @@ <h2><a href="#">Open Access in Practice: A Conversation with President Larry Kra

</article>

<article>
<article class="post">
<header>
<h2><a href="#">Open Access in Practice: A Conversation with President Larry Kramer of The Hewlett Foundation</a></h2>
<span class="byline">by <a href="#">Amanda Conway</a>, <a href="#">Ólafur Jónsson</a></span>
Expand All @@ -190,7 +190,7 @@ <h2><a href="#">Open Access in Practice: A Conversation with President Larry Kra
<p>In search of answers, we looked at past research, notably Andrea Wallace's Barriers to Open Access — Open GLAM, and asked more than 30 experts in the open culture movement. You can watch what they told us in our CC Open Culture VOICES vlog series. Here's a small sample of what we heard</p>
</article>

<article>
<article class="post">
<header>
<h2><a href="#">Open Access in Practice: A Conversation with President Larry Kramer of The Hewlett Foundation</a></h2>
<span class="byline">by <a href="#">Amanda Conway</a>, <a href="#">Ólafur Jónsson</a></span>
Expand All @@ -200,7 +200,7 @@ <h2><a href="#">Open Access in Practice: A Conversation with President Larry Kra
<p>In search of answers, we looked at past research, notably Andrea Wallace's Barriers to Open Access — Open GLAM, and asked more than 30 experts in the open culture movement. You can watch what they told us in our CC Open Culture VOICES vlog series. Here's a small sample of what we heard</p>
</article>

<article>
<article class="post">
<header>
<h2><a href="#">Open Access in Practice: A Conversation with President Larry Kramer of The Hewlett Foundation</a></h2>
<span class="byline">by <a href="#">Amanda Conway</a>, <a href="#">Ólafur Jónsson</a></span>
Expand All @@ -211,7 +211,7 @@ <h2><a href="#">Open Access in Practice: A Conversation with President Larry Kra
</article>


</div>
</article>

<nav class="pagination">
<ol>
Expand Down Expand Up @@ -285,16 +285,16 @@ <h2>Support Our Work</h2>
<p>Except where otherwise <a href="/policies/#license">noted</a>, content on this site is licensed under a <a href="/licenses/by/4.0/">Creative Commons Attribution 4.0 International license</a>. Icons by <a href="https://fontawesome.com/" target="_blank">Font Awesome</a>.</p>

<svg>
<use href="/vocabulary/svg/cc/icons/cc-icons.svg#cc-logo"></use>
<use href="../../../src/svg/cc/icons/cc-icons.svg#cc-logo"></use>
</svg>
<svg>
<use href="/vocabulary/svg/cc/icons/cc-icons.svg#cc-by"></use>
<use href="../../../src/svg/cc/icons/cc-icons.svg#cc-by"></use>
</svg>
</div>

</footer>

<script src="../../src/js/vocabulary.js"></script>
<script src="../../../src/js/vocabulary.js"></script>

</body>
</html>
</html>
Loading