-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL syntax in @font-face declarations for improved browser compatability #102
Fix URL syntax in @font-face declarations for improved browser compatability #102
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Vanessa082 please revert all formatting changes unrelated to this Issue. The only changes present within this PR should be the addition of quotes around the urls' values. |
@possumbilities I just did that now |
@Vanessa082 It looks like you haven't merged in more recent changes from the |
…ges present is the addition of qoute on the url()
918d268
to
2d8228f
Compare
Thank you @possumbilities I just updated |
@Vanessa082 Wonderful! Thank you. Approved. |
Fixes
Description
This pull request addresses an issue with incorrect URL syntax in the
@font-face
declarations within the CSS file. The URLs for the font files were not enclosed in quotes, which could lead to inconsistent font loading behavior across different browsers.Technical details
The implementation fixes the syntax by enclosing all
url()
values in single quotes. This change ensures that the CSS adheres to best practices and enhances compatibility with various browsers. The affected@font-face
declarations include those for "Roboto Condensed," "Source Sans Pro," and "CC Accidenz Commons."Tests
@font-face
declarations.url()
values are now properly enclosed in quotes.Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin