-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance accessibility by adding ARIA attributes and IDs to navigation elements #243
Enhance accessibility by adding ARIA attributes and IDs to navigation elements #243
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Faith-K-commits Hi! I added some comments that would need to repeat across the other contexts. I also believe you might have missed the sidebar menu(s) which appear on several contexts (like A PR here should address all occurrences of |
Hi @possumbilities |
Hello @possumbilities, I have made the changes in all occurances of |
Hi @Faith-K-commits Good work, there's a few more adjustments but you're getting close! |
Hi @possumbilities , thank you for your feedback. I have removed the redundant word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful! Approved. Thank you for this contribution!
You're welcome! |
Fixes
aria-labelled-by
oraria-label
, depending on markup present #238 by @Faith-K-commitsDescription
This pull request improves the accessibility of navigation elements by adding appropriate
aria-label
andaria-labelledby
attributes. These changes help screen readers better understand the purpose of the navigation sections.Technical details
aria-label
attribute has been added to provide clear labels for screen readers where the menu purpose was not explicitly labeled.aria-labelledby
has been applied when appropriate, referencing headings where present.Tests
To verify the changes:
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin