-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced span with figcaption #77
replaced span with figcaption #77
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Annahbellah This Issue is still set as Please see the Contribution Guidelines I will leave this PR open for now, but please follow the Contribution Guidelines in the future |
@possumbilities well acknowledged, I'm sorry for the mistake. |
Hi @Annahbellah Work here would need to address this in all locations, not just the one file. It would also need to verify that by changing the markup in this way that page rendering is not altered. |
…s inside the <figcaption> tag for improved accessibility and adherence to HTML5 standard
0b510b0
to
403f048
Compare
Thank you @possumbilities. I have worked on this like you instructed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Approved.
Fixes
Description
This pull request resolves the problem about the attribution markup in the image figures by replacing the with
. This helps in improving the semantic structure of the HTML.Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin