Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced span with figcaption #77

Conversation

Annahbellah
Copy link
Contributor

@Annahbellah Annahbellah commented Oct 4, 2024

Fixes

Description

This pull request resolves the problem about the attribution markup in the image figures by replacing the with

. This helps in improving the semantic structure of the HTML.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Annahbellah Annahbellah requested review from a team as code owners October 4, 2024 04:18
@Annahbellah Annahbellah requested review from TimidRobot, possumbilities, Dhruvi16 and nimishbongale and removed request for a team October 4, 2024 04:19
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 403f048
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6712d7449769830008f89f84
😎 Deploy Preview https://deploy-preview-77--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities
Copy link
Contributor

@Annahbellah This Issue is still set as status: tick work required Please do not submit PRs against Issues until they have moved to status: ready for work.

Please see the Contribution Guidelines

I will leave this PR open for now, but please follow the Contribution Guidelines in the future

@Annahbellah
Copy link
Contributor Author

@possumbilities well acknowledged, I'm sorry for the mistake.

@possumbilities
Copy link
Contributor

Hi @Annahbellah Work here would need to address this in all locations, not just the one file. It would also need to verify that by changing the markup in this way that page rendering is not altered.

…s inside the <figcaption> tag for improved accessibility and adherence to HTML5 standard
@Annahbellah Annahbellah force-pushed the fix-nested-anchor-tags-in-attribution-figure-and-improve-semantics branch from 0b510b0 to 403f048 Compare October 18, 2024 21:46
@Annahbellah
Copy link
Contributor Author

Thank you @possumbilities. I have worked on this like you instructed.

Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Fix Nested Anchor Tags in Attribution Figure and Improve Semantics
2 participants