-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to change colors #66
Comments
Hello @vbartusevicius , I am sorry to hear this. Best, |
This is one of my main concerns as well. That the styling doesn't use the features present in material ui (theme-ing) is a big surprise, and makes it hard to get the look-and-feel consistent when using standard material ui components along with those from this kit. The second issue being that we can't install and use these components as a normal library dependency in a sensible way. Love the stuff you've done with it, so if those two are fixed, it'll be a really nice addition to the material ui experience. |
Hello there @kaos , Thank you for your interest in working with our products, and sorry for this issue. Best, |
- Added hexToRgb function - Made all primary, success.. colors, linear gradients and box shadows to use the hexToRgb function - no more hardcoded colors - Solved #66
First of all - thank you for great job you did. The dashboard looks really great, but after we got used to it, we bumped into major issues:
At first it seems that primary color is defined in
material-dashboard-react.jsx
with nameprimaryColor
. That looked great, but:primaryBoxShadow
which uses hard-coded RGB values ofprimaryColor
.primaryCardHeader
- hardcoded RGBbuttonStyle.jsx
-buttonStyle.primary
uses hardcoded RGB for boxShadow.Same applies for all colors.
It is practically a rewrite for someone willing to use different color palette and total mess is guaranteed when one would like to update package.
In my opinion best approach would be to use custom Material-ui theme as this is how they suggest to customize components. If that's not possible I suggest to use some color manipulation package, like https://www.npmjs.com/package/color:
Sorry for criticism, but this is a main issue we decided to abandon further integration of this nice dashboard.
The text was updated successfully, but these errors were encountered: