Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/oob credential issuance verification #467

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Feat/oob credential issuance verification #467

merged 10 commits into from
Jan 30, 2024

Conversation

ankita-p17
Copy link
Contributor

@ankita-p17 ankita-p17 commented Jan 30, 2024 •
edited
Loading

What

  • Restore API to create OOB credential offer
  • WIP: OOB Proof Request

Why

  • Updated existing proof request create endpoint
  • Added the missing code block

How

NA

nishad-ayanworks and others added 10 commits December 20, 2023 18:46
@nishad-ayanworks
Merge pull request #363 from credebl/dev-to-main-oob
9298bd2 
feat: out of band
@nishad-ayanworks
Merge branch 'develop' of https://github.com/credebl/platform into de…
1ba7334 
…v-to-main-afj-auth
@KulkarniShashank
Merge pull request #396 from credebl/dev-to-main-afj-auth
298c083 
refactor: AFJ Authentication
@nishad-ayanworks
Merge branch 'develop' of https://github.com/credebl/platform into de…
e3e5812 
…v-to-main-afj-auth
@bhavanakarwade
Merge pull request #398 from credebl/dev-to-main-afj-auth
a5ef36e 
feat: Set organization to public by default
@KulkarniShashank
fix: removed the unnecessary logger from the agent-service module (#419)
62e3e40 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@ankita-p17
WIP:OOB Proof Request
6dbe66c 
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
@ankita-p17
WIP:OOB Proof Request
b4cea26 
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
@ankita-p17
Merge branch 'main' of https://github.com/credebl/platform into feat/…
2894562 
…oob-credential-issuance-verification
@ankita-p17
fix:OOB Credential Offer restore changes
9bc22dd 
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

amitpadmani-awts
amitpadmani-awts approved these changes Jan 30, 2024
View reviewed changes
Copy link

@amitpadmani-awts amitpadmani-awts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitpadmani-awts amitpadmani-awts merged commit 61f89eb into develop Jan 30, 2024
2 checks passed
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
c162392 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
f5b3b60 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
5a0f0dc 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
ee3ec04 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
a3e51df 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
@ankita-p17 @nishad-ayanworks
@KulkarniShashank @bhavanakarwade
Feat/oob credential issuance verification (#467)
340ca48 
* fix: removed the unnecessary logger from the agent-service module (#419)

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* WIP:OOB Proof Request

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

* fix:OOB Credential Offer restore changes

Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>

---------

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: ankita_patidar <ankita.patidar@ayanworks.com>
Co-authored-by: Nishad Shirsat <103021375+nishad-ayanworks@users.noreply.github.com>
Co-authored-by: Nishad <nishad.shirsat@ayanworks.com>
Co-authored-by: Shashank Kulkarni <44693969+KulkarniShashank@users.noreply.github.com>
Co-authored-by: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitpadmani-awts amitpadmani-awts amitpadmani-awts approved these changes

@pallavighule pallavighule Awaiting requested review from pallavighule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankita-p17 @amitpadmani-awts @nishad-ayanworks @KulkarniShashank @bhavanakarwade