Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: required attributes in create schema API #521

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

pranalidhanavade
Copy link
Contributor

What

  • Added isRequired field in create schema API in schema service.
  • Done changes in dto validations for following APIs:-
  1. POST /orgs/{orgId}/credentials/offer Issuer create a credential offer
  2. POST /orgs/{orgId}/credentials/oob/email Creates a out-of-band credential offer and sends them via emails
  3. POST /orgs/{orgId}/credentials/oob/offer Create out-of-band credential offer
  • Added isRequired field in request endorsement API in ecosystem service.

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pranalidhanavade pranalidhanavade linked an issue Feb 19, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit ea1de32 into develop Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required attributes in Create schema API (back-end)
2 participants