Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added validation for network and ledgerId update when did update #789

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix: added validation for network and ledgerId update when did update #789

merged 4 commits into from
Jun 19, 2024

Conversation

KulkarniShashank
Copy link
Contributor

What

  • Implemented validation logic to ensure network and ledgerId are correctly updated when a DID is updated.

Why

  • Previously, there was no validation in place for network and ledgerId during a DID update. This could lead to inconsistencies and potential issues with the integrity of the data.

How

  • Added validation checks in the update function for DIDs.
  • Modified the update process to include conditions that check the validity of the network and ledgerId.
  • Updated relevant tests to cover scenarios where the network and ledgerId are updated to ensure they pass the new validation rules.

fix: added validation for network and ledgerId update when did update
7d268a0 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@KulkarniShashank KulkarniShashank self-assigned this Jun 18, 2024
fix: changes the veriable name in the setPrimaryDid function
d0fbe4c 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
GHkrishna
GHkrishna approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

refactor: added the NA for the no network DID for create DID and set …
42df8dd 
…primary DID

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
fix: changes enum NA to Not_Applicable
e635e70 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KulkarniShashank KulkarniShashank merged commit 49fa9a8 into develop Jun 19, 2024
2 checks passed
@ankita-p17 ankita-p17 deleted the fix/primary-did-different-network branch July 10, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

Assignees

@KulkarniShashank KulkarniShashank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KulkarniShashank @GHkrishna @tipusinghaw