Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch clientId and client secret by userId #790

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: fetch clientId and client secret by userId #790

merged 1 commit into from
Jun 19, 2024

Conversation

KulkarniShashank
Copy link
Contributor

@KulkarniShashank KulkarniShashank commented Jun 19, 2024 •
edited
Loading

What

  • Modify the logic to fetch clientId and client secret using userId.

Why

  • To ensure that authentication details are correctly retrieved based on the user's unique identifier.

How

  • Updated the relevant functions to query the database using userId to get clientId and client secret.
  • Refactored the authentication module to incorporate the new logic.
  • Added tests to verify that clientId and client secret are correctly fetched by userId.

fix: clientId and client secret fetch by userId
9bcc3c2 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@KulkarniShashank KulkarniShashank self-assigned this Jun 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KulkarniShashank KulkarniShashank merged commit ffca3a1 into develop Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shitrerohit shitrerohit shitrerohit approved these changes

Assignees

@KulkarniShashank KulkarniShashank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KulkarniShashank @shitrerohit