Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance wallet deletion validation and add null check for orgId in schema and credential-definition #791

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

KulkarniShashank
Copy link
Contributor

What

  • Improved the validation logic for deleting a wallet, ensuring that references in related tables are properly checked.
  • Added validation to ensure orgId is null or not in schema and credential definition entities.

Why

  • To prevent accidental deletion of wallets that are still referenced in other parts of the database, which could lead to data integrity issues.
  • To ensure that orgId is always present in schema and credential definition entities, null reference as an optional.

How

  • Implemented additional validation checks before allowing the deletion of a wallet, ensuring no existing references are left in related tables.
  • Added validation rules in the schema and credential definition code to enforce that orgId null as an optional

…n for schema and credential-def

Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
bhavanakarwade
bhavanakarwade approved these changes Jun 19, 2024
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Copy link

Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@KulkarniShashank KulkarniShashank merged commit 466a6f1 into develop Jun 19, 2024
2 checks passed
@bhavanakarwade bhavanakarwade requested review from bhavanakarwade and removed request for bhavanakarwade July 1, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants