Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: applied validations on schema url attributes while creating an offer #792

Merged
merged 4 commits into from
Jun 24, 2024
Merged

refactor: applied validations on schema url attributes while creating an offer #792

merged 4 commits into from
Jun 24, 2024

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Implemented validate schema URL attributes functionality during issuance by connection ID.
  • Implemented validate schema URL attributes functionality during out-of-band issuance.
  • Implemented validate schema URL attributes functionality during out-of-band issuance using email.

Why?

  • To make sure the issued attributes match the defined schema, ensuring data accuracy.

@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld
6e1d3de 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into re…
100c54d 
…factor/validate-schema-url-attributes
@bhavanakarwade bhavanakarwade self-assigned this Jun 19, 2024
@bhavanakarwade bhavanakarwade requested a review from GHkrishna June 19, 2024 11:52
GHkrishna
GHkrishna approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bhavanakarwade bhavanakarwade linked an issue Jun 19, 2024 that may be closed by this pull request
feat: Validate attributes and W3C schema URL while issuance #700
Closed
@bhavanakarwade
fix: resolved conflicts
0f8edbb 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
tipusinghaw
tipusinghaw approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavanakarwade bhavanakarwade merged commit 29123f5 into develop Jun 24, 2024
1 check passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tipusinghaw tipusinghaw deleted the refactor/validate-schema-url-attributes branch June 24, 2024 06:01
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
6f29410 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
b7f48f6 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
4f53f4d 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
f1e9728 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
9b486f5 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
fb397c3 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
refactor: applied validations on schema url attributes for jsonld (#792)
f29375a 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

Assignees

@bhavanakarwade bhavanakarwade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Validate attributes and W3C schema URL while issuance
3 participants
@bhavanakarwade @GHkrishna @tipusinghaw