Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dynamic parameter implementation in email-template for sending verification email. #810

Merged
merged 3 commits into from
Jun 25, 2024
Merged

feat: added dynamic parameter implementation in email-template for sending verification email. #810

merged 3 commits into from
Jun 25, 2024

Conversation

ganeshawle25
Copy link
Contributor

What

  • Changed send verification email functionalities for sending dynamic email according organisation.
  • Added brandLogoUrl , platformName attributes in UserEmailVerificationDto class and added these attributes in function call.
  • Updates email template according to dynamic values.

Why

  • To send verification email dynamically according to organisation details .

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ganeshawle25 ganeshawle25 changed the title feat: added dynamic parameter implementation for email-template feat: added dynamic parameter implementation in email-template for sending verification email. Jun 25, 2024
bhavanakarwade
bhavanakarwade approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@bhavanakarwade bhavanakarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

tipusinghaw
tipusinghaw approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshawle25 ganeshawle25 merged commit f675411 into develop Jun 25, 2024
2 checks passed
@ganeshawle25 ganeshawle25 deleted the feat/email-template-changes branch June 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@shitrerohit shitrerohit Awaiting requested review from shitrerohit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshawle25 @tipusinghaw @bhavanakarwade