Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dynamic support to issuance email template. #849

Merged
merged 5 commits into from
Jul 16, 2024
Merged

feat: added dynamic support to issuance email template. #849

merged 5 commits into from
Jul 16, 2024

Conversation

ganeshawle25
Copy link
Contributor

@ganeshawle25 ganeshawle25 commented Jul 16, 2024 •
edited
Loading

What

  • Added 'organizationLogoUrl' and 'platformName' in request parameter for issue-bulk-credentials API.
  • Refactored issue-bulk-credentials API for issuance.

Why

  • While issuing credentials for user need to send issuance email which is specific to organisation.

@ganeshawle25
feat: changed issuance email template for EDUCRED
71426db 
Signed-off-by: Ganesh Nawle <ganesh.nawle@ayanworks.com>
@ganeshawle25
fix:refactored preview uploaded file api changed query Param to path …
1c27667 
…param

Signed-off-by: Ganesh Nawle <ganesh.nawle@ayanworks.com>
@ganeshawle25
added-logger statement
3a46080 
Signed-off-by: Ganesh Nawle <ganesh.nawle@ayanworks.com>
@ganeshawle25
fix:Minor fixes
6a1d97a 
Signed-off-by: Ganesh Nawle <ganesh.nawle@ayanworks.com>
@ganeshawle25
fix:removed all console logs
e43829f 
Signed-off-by: Ganesh Nawle <ganesh.nawle@ayanworks.com>
@ganeshawle25 ganeshawle25 self-assigned this Jul 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bhavanakarwade
bhavanakarwade approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@bhavanakarwade bhavanakarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

tipusinghaw
tipusinghaw approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshawle25 ganeshawle25 merged commit 29eb16b into develop Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@shitrerohit shitrerohit Awaiting requested review from shitrerohit

Assignees

@ganeshawle25 ganeshawle25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshawle25 @tipusinghaw @bhavanakarwade