Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: store holder role in user role mapping table #857

Merged
merged 1 commit into from
Jul 18, 2024
Merged

refactor: store holder role in user role mapping table #857

merged 1 commit into from
Jul 18, 2024

Conversation

KulkarniShashank
Copy link
Contributor

What

Refactor the code to store the holder role in the user role mapping table.

Why

Storing the holder role in a dedicated user role mapping table enhances maintainability, scalability, and clarity in role management.

How

  • Created a new user role mapping table to store user roles.
  • Updated the existing code to insert and retrieve holder roles from the new table.
  • Modified related functions and queries to accommodate the new structure.
  • Added necessary migrations to update the database schema.

refactor: store holder role in user role mapping table
2387a61 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@KulkarniShashank KulkarniShashank self-assigned this Jul 18, 2024
@KulkarniShashank KulkarniShashank added the enhancement New feature or request label Jul 18, 2024
@KulkarniShashank KulkarniShashank linked an issue Jul 18, 2024 that may be closed by this pull request
feat: holder role guard #853
Open
5 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tipusinghaw
tipusinghaw approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit 9fc7184 into develop Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

Assignees

@KulkarniShashank KulkarniShashank

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: holder role guard
2 participants
@KulkarniShashank @tipusinghaw