Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: attributes payload changes while creating a proofrequest #907

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Refactor create OOB proof request function

Why?

  • To ensure that attributes are correctly included when creating a proof request

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Copy link

@bhavanakarwade bhavanakarwade merged commit 8fee70b into develop Aug 14, 2024
2 checks passed
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants