Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:Get schema details from LocalStorage for view schema page #241

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

pranalidhanavade
Copy link
Contributor

What?

  • Get schema details from LocalStorage

Why?

  • We fetched data from LocalStorage to reduce the load on the application, as fetching it from the API was causing load.

@pranalidhanavade pranalidhanavade added the enhancement New feature or request label Sep 8, 2023
@pranalidhanavade pranalidhanavade self-assigned this Sep 8, 2023
@pranalidhanavade pranalidhanavade changed the title update:Get schema details from LocalStorage Refactor:Get schema details from LocalStorage Sep 8, 2023
@pranalidhanavade pranalidhanavade changed the title Refactor:Get schema details from LocalStorage refactor:Get schema details from LocalStorage for view schema page Sep 8, 2023
Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

const schemaName = parts[2];
const version = parts[3];
console.log("schemaId::::", schemaId)
const schemaDidObject = JSON.parse(schemaDetails)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove logs



await setToLocalStorage(storageKeys.SCHEMA_ID, schemaId)
// setSchemaDetails(schemaDidObject)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented code

@tipusinghaw tipusinghaw merged commit 3e5b077 into develop Sep 8, 2023
@tipusinghaw tipusinghaw deleted the view-schema-details branch September 8, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants