Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: api's for connection issuance and verification #298

Merged
merged 6 commits into from
Sep 21, 2023
Merged

refactor: api's for connection issuance and verification #298

merged 6 commits into from
Sep 21, 2023

Conversation

16-karan
Copy link
Contributor

WHAT

  • Refactored the API endpoints in the Connection, Issuance and Verification.
  • Improved code Organisation and readability.
  • Updated API documentation.

WHY

  • To provide better support for future feature development.
  • To make the API more user-friendly and intuitive for developers.

How

  • Reviewed the existing Code base in the Connection, Issuance and Verification.
  • Refactored the API endpoints using best practices and design patterns.
  • Updated API documentation to reflect the changes made.
  • Ran tests to ensure that the refactored code functions correctly.

bhavanakarwade and others added 5 commits September 18, 2023 19:39
@bhavanakarwade
feat: refactor api's for connection verification and issuance module
5c8163c 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
fix: refactor creddef by id api
bbeb0ed 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@16-karan
Merge branch 'develop' of https://github.com/credebl/studio into refa…
80f9ae3 
…ctor-api-issuance-verification-connection

Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
Merge branch 'develop' of https://github.com/credebl/studio into refa…
736efbd 
…ctor-api-issuance-verification-connection

Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
refactor api standardization and bug fixes
a04de65 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan 16-karan self-assigned this Sep 21, 2023
@16-karan
review changes
8778b6f 
Signed-off-by: karan <karan.tompe@ayanworks.com>
nishad-ayanworks
nishad-ayanworks approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@16-karan 16-karan merged commit 405a50d into develop Sep 21, 2023
@nishad-ayanworks nishad-ayanworks deleted the refactor-api-issuance-verification-connection branch December 6, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

Assignees

@16-karan 16-karan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@16-karan @nishad-ayanworks @bhavanakarwade