Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ecosystem alignment, received invitation, updated interfaces, added success alert, added title tooltip, handled button loading, improved interfaces and logic for storage #567

Merged
merged 5 commits into from
Feb 8, 2024
Merged

fix: ecosystem alignment, received invitation, updated interfaces, added success alert, added title tooltip, handled button loading, improved interfaces and logic for storage #567

merged 5 commits into from
Feb 8, 2024

Conversation

16-karan
Copy link
Contributor

@16-karan 16-karan commented Feb 8, 2024

What

  • Handled ecosystem alignment
  • Handled page break for the received invitation
  • Updated interfaces,
  • Added success alert messages in issuance and verification
  • Added title tooltip create and endorsement request
  • Handled button loading in issuance and verification
  • Improved interfaces
  • Handled local storage

Why

  • Optimize the code
  • For the optimal user experience

@16-karan 16-karan self-assigned this Feb 8, 2024
@16-karan
fix: issues from live tracker
6820220 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
handled sonar suggestions
ed13e00 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@16-karan
added tooltip
acd0bb1 
Signed-off-by: karan <karan.tompe@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

nishad-ayanworks
nishad-ayanworks approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit b933d08 into develop Feb 8, 2024
5 checks passed
@pranalidhanavade pranalidhanavade deleted the live-issues-tracker branch March 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

@sanjay-k1910 sanjay-k1910 Awaiting requested review from sanjay-k1910

Assignees

@16-karan 16-karan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@16-karan @nishad-ayanworks