Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve the value of const initializers before type-checking #149

Merged
merged 2 commits into from
Mar 12, 2019
Merged

fix: resolve the value of const initializers before type-checking #149

merged 2 commits into from
Mar 12, 2019

Conversation

kevin-greene-ck
Copy link
Contributor

resolves #138

Resolve the value of identifiers used as const values before type-checking.

ramakrishna-battala-ck
ramakrishna-battala-ck approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@ramakrishna-battala-ck ramakrishna-battala-ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevin-greene-ck kevin-greene-ck merged commit 205716a into master Mar 12, 2019
@hayes hayes mentioned this pull request Mar 27, 2019
Closed
@kevin-greene-ck kevin-greene-ck deleted the const-type branch April 8, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramakrishna-battala-ck ramakrishna-battala-ck ramakrishna-battala-ck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation error when referencing existing variables such as defined strings in set<string>
2 participants
@kevin-greene-ck @ramakrishna-battala-ck