Skip to content

Commit

Permalink
bring back checked checkboxes
Browse files Browse the repository at this point in the history
  • Loading branch information
@Chaosmeister
Chaosmeister authored Feb 16, 2023
1 parent afb01d1 commit b2d36f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vendor/leblanc-simon/parsedown-checkbox/ParsedownCheckbox.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ protected function checkboxChecked($text)
$text = self::escape($text);
}

return '<input type="checkbox" disabled /> ' . $this->format($text);
return '<input type="checkbox" checked disabled /> ' . $this->format($text);
}

/**
Expand Down

10 comments on commit b2d36f7

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, copy paste fail.

@Chaosmeister
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye 😄
luckily a mate found it right after I updated our instance

I wasn't sure if you want to create another release for this or just update the release packages stealthily

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at this yesterday, and if I can figure out how to put something in there to determine which line, I could actually add the ability to check/uncheck them boxes.

@Chaosmeister
Copy link
Collaborator Author

@Chaosmeister Chaosmeister commented on b2d36f7 Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a plugin for this, kinda hacky but works

https://github.com/Chaosmeister/CCIT

we could merge it into markdownplus

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye 😄 luckily a mate found it right after I updated our instance

I wasn't sure if you want to create another release for this or just update the release packages stealthily

doesn't matter, probably wise to just make a new release.

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a plugin for this, kinda hacky but works

https://github.com/Chaosmeister/CCIT

does this save after click? I'll check this out!

@Chaosmeister
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a plugin for this, kinda hacky but works
https://github.com/Chaosmeister/CCIT

does this save after click? I'll check this out!

exactly

count the amount of checkboxes and tag them
send a comment/description toggle-update with the checkboxnumber
let some regex find the checkbox with that number

@Chaosmeister
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the merge we could get rid of the initial disabled state. that would save a tiny bit of cpu

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just updated the current release, too lazy to make a new one. if anyone happened to download that one and posts an issue, ill just tell them to reinstall :)

@creecros
Copy link
Owner

@creecros creecros commented on b2d36f7 Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the merge we could get rid of the initial disabled state. that would save a tiny bit of cpu

ya, i'd say combine that into markdownplus, i'll leave that up to you though, don't want to steal your repo. feel free to throw your name on this one if you do.

at the very least, throw a callout to it in this readme, so people will know about it. i had no idea!

Please sign in to comment.