Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MarkdownPlusHelper.php #26

Merged
merged 1 commit into from
May 31, 2024

Conversation

colonelpopcorn
Copy link
Contributor

This allows us to override functionality at our pace. This should be relatively safe since Kanboard is in maintenance mode.

@colonelpopcorn
Copy link
Contributor Author

@creecros Could I get a review on this PR, any concerns with extending the original helper?

@creecros
Copy link
Owner

When i get a moment I will.

@RainerBielefeld
Copy link
Collaborator

I did some first tests with new MarkdownPlusHelper.php, heals the comments problem, until now no bad interactions seen.

My Configuration (KANBOARD installation for testing)

  • Application version: 1.2.36

  • PHP version: 8.3.6

  • PHP SAPI: fpm-fcgi

  • HTTP Client: cURL

  • OS version: Linux 5.4.0-181-generic

  • Database driver: mysql

  • Database version: 10.5.23-MariaDB-1:10.5.23+maria~ubu2004-log

  • Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:117.0a) Gecko/20100101 SeaMonkey/2.53.18, Build 20240329110002

  • Profile Language: English

  • Plugins:

    • Wiki 0.3.3a by Alfred
    • MarkdownPlus with modfied MarkdownPlusHelper.php (by colonelpopcorn 2024-05-20)

I will do more tests with full Plugins set, soon.

@creecros creecros merged commit 47370bd into creecros:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants