Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP parameters proposal improvements #2

Merged
merged 9 commits into from
Jan 26, 2022
Merged

CMP parameters proposal improvements #2

merged 9 commits into from
Jan 26, 2022

Conversation

crenshaw-dev
Copy link
Owner

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@crenshaw-dev
docs: improvements based on convo w/ Alex & Leo
338acf1 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
docs: further clarify env var names
b4b7ec9 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: merge upstream
3ed2b5b 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: fix broken links
3fa17f8 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
leoluz
leoluz reviewed Jan 26, 2022
View reviewed changes
docs/proposals/parameterized-config-management-plugins.md Outdated
title: Values File
tooltip: Path of a Helm values file to apply to the chart.
# The (optional) generated announcement is combined with the declarative announcement (if present).
announcement:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this related to the dynamic parameters? If so, how about changing: s/announcement/dynamicParameters?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I like that.

@crenshaw-dev
docs: add comparison between integrated and separate UI/param config
862fa8d 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: make 2nd example match 1st more closely
4fac60e 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: split pro into 2 bullet points
f6debd6 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: add another pro
ac43cec 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
chore: add another con
20b02a3 
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev merged commit c2b3c02 into cmp-parameters-proposal Jan 26, 2022
@crenshaw-dev crenshaw-dev deleted the cmp-parameters-proposal-improvements branch January 26, 2022 18:26
crenshaw-dev pushed a commit that referenced this pull request Jun 5, 2023
@reggie-k
Merge pull request #2 from crenshaw-dev/create-job-action-changes
9632537 
small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @leoluz