Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add ante msg filter for mixed batch msg, deprecated module msgs #160

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

crypin
Copy link
Member

@crypin crypin commented Jun 21, 2023

Description

Continued PR from #159

Tasks

  • Add antehandler level msg filter for mixed batch msgs
  • Add other deprecated module's msg ( liquidity, claim, farming )
  • Add test cases
  • refactoring

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crypin crypin marked this pull request as ready for review June 21, 2023 05:12
app/ante/msg_ante.go Outdated Show resolved Hide resolved
@crypin crypin requested a review from kingcre June 21, 2023 06:17
Copy link
Contributor

@kingcre kingcre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crypin crypin merged commit bacb608 into amm-module Jun 21, 2023
@kingcre kingcre deleted the amm-module-add-midblock-batch-msgs-filter branch August 1, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants