Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix pool query (include missing fields in response) #181

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: fix pool query (include missing fields in response) #181

merged 1 commit into from
Aug 18, 2023

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Aug 17, 2023

Description

Add missing total_liquidity, rewards_pool and min_order_quantity field in the response.

@kingcre kingcre self-assigned this Aug 17, 2023
@github-actions github-actions bot added the x/amm label Aug 17, 2023
@kingcre kingcre marked this pull request as ready for review August 17, 2023 19:08
crypin
crypin approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@crypin crypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, (ditto #180 (review))

@kingcre kingcre merged commit 23600f6 into amm-module Aug 18, 2023
15 of 17 checks passed
@kingcre kingcre deleted the fix/pool-query branch August 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypin crypin crypin approved these changes

@richard-bachman richard-bachman Awaiting requested review from richard-bachman richard-bachman is a code owner

@lv-koala lv-koala Awaiting requested review from lv-koala lv-koala is a code owner

Assignees

@kingcre kingcre

Labels
x/amm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingcre @crypin